Attempt to clarify why we add many aggsig conditions in make_and_send_big_cost_sb #19026
+42
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
AmineKhaldi
force-pushed
the
proposal_for_less_magic
branch
from
4d6a239 to
d9257c3
Compare
arvidn
reviewed
Dec 11, 2024
AmineKhaldi
force-pushed
the
proposal_for_less_magic
branch
from
d9257c3 to
304f479
Compare
arvidn
reviewed
Dec 11, 2024
AmineKhaldi
force-pushed
the
proposal_for_less_magic
branch
from
304f479 to
3387000
Compare
arvidn
approved these changes
Dec 11, 2024
arvidn
merged commit 817a67a
into
Chia-Network:remove-block-fill-rate-limit
356 checks passed
pmaslana
pushed a commit
that referenced
this pull request
Dec 12, 2024
* remove the block fill rate limit of 70% when farming a block * Addendum to 100% block fill rate. (#19006) * break down 'magic number' in test into its components * Attempt to clarify why we add many aggsig conditions in make_and_send_big_cost_sb (#19026) Attempt to clarify why we add many aggsig conditions in make_and_send_big_cost_sb. --------- Co-authored-by: Amine Khaldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal related to #19005 (comment).